14 messages in org.apache.maven.devRe: [VOTE] Release Maven Javadoc Plug...| From | Sent On | Attachments |
|---|---|---|
| Vincent Siveton | Aug 1, 2008 7:01 pm | |
| Benjamin Bentmann | Aug 2, 2008 1:44 am | |
| Vincent Siveton | Aug 2, 2008 4:30 am | |
| Benjamin Bentmann | Aug 2, 2008 5:05 am | |
| Vincent Siveton | Aug 2, 2008 5:25 am | |
| Hervé BOUTEMY | Aug 2, 2008 6:11 am | |
| Benjamin Bentmann | Aug 2, 2008 6:16 am | |
| Hervé BOUTEMY | Aug 2, 2008 6:28 am | |
| Hervé BOUTEMY | Aug 2, 2008 7:10 am | |
| Benjamin Bentmann | Aug 2, 2008 7:54 am | |
| Vincent Siveton | Aug 2, 2008 10:24 am | |
| Vincent Siveton | Aug 2, 2008 10:26 am | |
| Benjamin Bentmann | Aug 2, 2008 10:37 am | |
| Vincent Siveton | Aug 2, 2008 12:01 pm |
| Subject: | Re: [VOTE] Release Maven Javadoc Plugin version 2.5 | |
|---|---|---|
| From: | Vincent Siveton (vinc...@gmail.com) | |
| Date: | Aug 2, 2008 4:30:42 am | |
| List: | org.apache.maven.dev | |
Hi Benjamin,
Thanks to spot it! I will revert the release and call a new one.
So by default, we have now: - encoding = ${project.build.sourceEncoding} - docencoding = ${project.reporting.outputEncoding} - charset = null
And if charset == null, charset = docencoding
I will add a faq about this logic.
Also, I noticed in the Javadoc tool documentation: -encoding "If this option is not specified, the platform default converter is used." Ok Hervé displays a warn about build platform dependent if null but the -encoding param is not passed in the Javadoc tool. -docencoding "If you omit this option but use -encoding, then the encoding of the generated HTML files is determined by -encoding." We need to reflect this logic and NOT using UTF-8 which is actually the default.
Cheers,
Vincent
2008/8/2 Benjamin Bentmann <benj...@udo.edu>:
Hi Vincent,
We solved around 30 issues:
http://jira.codehaus.org/secure/ReleaseNote.jspa?version=14120&styleName=Text&projectId=11138
The handling of the charset parameter I proposed to Hervé in MJAVADOC-206 gives rise to misbehavior. Imagine the following plugin configuration:
<configuration> <docencoding>ISO-8859-1</docencoding> </configuration>
i.e. the generated HTML files are encoded using Latin-1. However, the charset written in the <META> tag will state "text/html; charset=UTF-8", potentially making a browser render garbage characters.
I just fixed that, so maybe it's worth to include this for the release. Sorry, that I didn't spot this earlier.
Benjamin